[gnutls-devel] GnuTLS | restrict allowlisting api to before priority string initialization (!1533)
Read-only notification of GnuTLS library development activities
gnutls-devel at lists.gnutls.org
Thu Aug 11 09:38:31 CEST 2022
Alexander Sosedkin commented on a discussion on lib/config_int.h: https://gitlab.com/gnutls/gnutls/-/merge_requests/1533#note_1058135737
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public License
> + * along with this program. If not, see <https://www.gnu.org/licenses/>
> + *
> + */
> +/* Code split off from priority.c, `struct cfg` and some operations on it */
> +#ifndef GNUTLS_LIB_CONFIG_INT_H
> +#define GNUTLS_LIB_CONFIG_INT_H
> + * struct cfg
> Is this splitting really needed?
No, but priority.c is growing out of control and I felt bad making it even larger.
> I would try to keep struct definitions in .c for better encapsulation, unless there is a good reason to expose them library wide.
`priority.c` is the sole user of the definition. I'm not sure what you're proposing, renaming it to `cfg.c` and including it as `cfg.c` from `priority.c`?
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1533#note_1058135737
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Gnutls-devel