[gnutls-devel] Guile-GnuTLS | Draft: Add the HMAC functions (!5)
Read-only notification of GnuTLS library development activities
gnutls-devel at lists.gnutls.org
Fri Dec 23 11:20:15 CET 2022
civodul started a new discussion on guile/src/core.c: https://gitlab.com/gnutls/guile/-/merge_requests/5#note_1219872476
> weak_refs = scm_make_weak_key_hash_table (scm_from_int (42));
> weak_refs = scm_permanent_object (weak_refs);
> +#ifdef HAVE_GNUTLS_HMAC_GET_KEY_SIZE
> + scm_add_feature ("gnutls-hmac-key-size");
> +#endif /* HAVE_GNUTLS_HMAC_GET_KEY_SIZE */
Instead of using `scm_add_feature` and `NOT_PROVIDED`, how about placing the whole `scm_gnutls_hmac_key_size` definition in `#ifdef HAVE_GNUTLS_HMAC_GET_KEY_SIZE`?
That way user code could check `(defined? 'hmac-key-size)` and it would immediately fail, and possibly get an unbound-variable warning at build time, if it uses the missing procedure.
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/guile/-/merge_requests/5#note_1219872476
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Gnutls-devel