[gnutls-devel] GnuTLS | 3.7.4 tarball lacks gtk-doc macro (#1341)

[Read-only notification of GnuTLS library development activities]

Sam James created an issue: https://gitlab.com/gnutls/gnutls/-/issues/1341



Hi!

Thanks for another release of GnuTLS :)

3.7.4's `./configure` lacks support for `--{enable,disable}-gtk-doc`. Noticed when working on packaging 3.7.4 for Gentoo. It took me a little while to figure it out given `configure.ac` still contains:
```

dnl
dnl check for gtk-doc
dnl
m4_ifdef([GTK_DOC_CHECK], [
GTK_DOC_CHECK([1.14],[--flavour no-tmpl])
],[
AM_CONDITIONAL([ENABLE_GTK_DOC], false)
])
# needed for some older versions of gtk-doc
m4_ifdef([GTK_DOC_USE_LIBTOOL], [], [
AM_CONDITIONAL([GTK_DOC_USE_LIBTOOL], false)
])
```

I realised after diffing 3.7.3 and 3.7.4's tarballs (I won't bore you with all the relevant snippets, just enough to show the issue):
```
--- /tmp/pkgdiff/portage/net-libs/gnutls-3.7.3-r1/work/gnutls-3.7.3/aclocal.m4  2022-01-18 07:07:52.000000000 +0000
+++ /tmp/pkgdiff/portage/net-libs/gnutls-3.7.4/work/gnutls-3.7.4/aclocal.m4     2022-03-17 10:11:32.000000000 +0000
@@ -1611,7 +1611,6 @@ m4_include([m4/gettext.m4])
 m4_include([m4/gettimeofday.m4])
 m4_include([m4/gnulib-common.m4])
 m4_include([m4/gnulib-comp.m4])
-m4_include([m4/gtk-doc.m4])
 m4_include([m4/guile.m4])
 m4_include([m4/hooks.m4])
 m4_include([m4/host-cpu-c-abi.m4])
[...]
```

As per the `configure.ac` extract quoted above, the presence of the option is "automagic" based on whether `gtk-doc` (or at least `gtk-doc-am`) is installed on the system used to produce the release tarball (`make dist`).

I suspect what happened is @ZoltanFridrich didn't have `gtk-doc` installed in the environment used to generate the 3.7.4 release.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1341
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220318/c20fee2b/attachment-0001.html>