[gnutls-devel] GnuTLS | gnutlsxx: become header-only library (!1622)
Read-only notification of GnuTLS library development activities
gnutls-devel at lists.gnutls.org
Fri Nov 25 10:24:11 CET 2022
Daiki Ueno commented on a discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/1622#note_1185532049
Sorry, I thought that you were still working on that change (as the CI has some error). Yes, I agree that it would be nice header-only is default.
Regarding this [commit](https://gitlab.com/gnutls/gnutls/-/merge_requests/1622/diffs?commit_id=fd907d08893db6e0fa9bd968296f6dbc2b96e192), I would suggest adding stubs only for public symbols. For that, it might be easier to organize the change like:
```c
#ifdef ENABLE_SRP
void
gnutls_srp_set_client_credentials_function(gnutls_srp_client_credentials_t
cred,
gnutls_srp_client_credentials_function
* func)
{
/* proper implementation of this API function */
}
const char *gnutls_srp_server_get_username(gnutls_session_t session)
{
/* proper implementation of this API function */
}
...
#else
void
gnutls_srp_set_client_credentials_function(gnutls_srp_client_credentials_t
cred,
gnutls_srp_client_credentials_function
* func)
{
/* stub, do nothing */
}
const char *gnutls_srp_server_get_username(gnutls_session_t session)
{
/* stub, do nothing but returning NULL */
}
...
#endif
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1622#note_1185532049
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20221125/f776115d/attachment.html>
More information about the Gnutls-devel
mailing list