[gnutls-devel] GnuTLS | added clientHello extension permutation (!1737)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1737 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on lib/hello_ext.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1737#note_1337631264

> +		return gnutls_assert_val(ret);
> +
> +	/* oderdering dumbfw and pre_shared_key as last extensions */

Can't we simply `shuffle_arr(shuffled_n, MAX_EXT_TYPES - 2)`?

Also typo: "orderdering" → "ordering"

--
  
Daiki Ueno started a new discussion on lib/hello_ext.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1737#note_1337631266

>  
> +static
> +int shuffle_arr(uint8_t * arr, uint8_t sz)

Actually there is a special enum type `extensions_t`. So I would make this function more specific like:
```c
static int shuffle_exts(extensions_t *exts, size_t size) {
  ...
}
```


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1737
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20230401/4c91c544/attachment.html>