[gnutls-devel] GnuTLS | certtool: reject negative serial numbers (!1739)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Tue Apr 4 02:51:45 CEST 2023

Elias Gustafsson created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1739

Project:Branches: Eligus/gnutls:certtool-negative-serial to gnutls/gnutls:master
Author:   Elias Gustafsson

According to RFC 5280 section, certificate serial numbers must be positive integers, so `certtool` should reject hexadecimal serial numbers that would be interpreted as negative numbers. This patch adds checks that reject all serial numbers with the high bit set to 1.

Fixes #1237

## Checklist
 * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [ ] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [x] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1739
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20230404/6f0fc350/attachment-0001.html>

More information about the Gnutls-devel mailing list