[gnutls-devel] GnuTLS | src: print_info: prefer gnutls_psk_server_get_username2 (!1730)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Mon Apr 24 18:54:28 CEST 2023




Alexander Sosedkin started a new discussion on lib/psk.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1730#note_1364982434

>  	if (info == NULL)
>  		return NULL;
>  
> -	if (info->username[0] != 0

To me, it looks like we've lost a check that `info->username` is not an empty string (`if ('\0` && ...)` -> `if (!NULL && !NULL)`). Is that the case? acceptable? intended?

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1730#note_1364982434
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20230424/821d37a2/attachment.html>


More information about the Gnutls-devel mailing list