[PATCH gpgme] qt: Fix DLL version in cmake config files

Ingo Klöcker kloecker at kde.org
Sat Jul 8 21:53:34 CEST 2023

On Samstag, 8. Juli 2023 18:01:20 CEST Biswapriyo Nath wrote:
> > I think this is still wrong because it should certainly be
> > @resolved_bindir@ as below because the DLL is installed in bindir.
> Yes, I was going to send that patch after this one is merged. Should I
> send both fixes in one patch?

Okay. I have committed your patch and also fixed the path. Thanks!

> > Makes me wonder when/how IMPORTED_LOCATION is used because, apparently, we
> > never had any problems linking libkleo and kleopatra against QGpgME with
> > MinGW despite IMPORTED_LOCATION pointing to a not existing file.
> It seems that the `find_package(QGpgme CONFIG)` call succeed if
> QGpgmeConfig.cmake and QGpgmeConfigVersion.cmake file is present. The
> existence of .dll or .dll.a file was not checked by cmake.

Indeed. At least, when using Qt 5. It wasn't checked because of typos in the 
variable names which made the loop that should have checked the files an empty 
loop. I have fixed this and also avoided the duplication of the file paths.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.gnupg.org/pipermail/gnupg-devel/attachments/20230708/1b01ee46/attachment.sig>

More information about the Gnupg-devel mailing list