[gnutls-devel] GnuTLS | [Draft] Use faketime instead of datefudge (!1716)

[Read-only notification of GnuTLS library development activities]

Andreas Metzler commented:


I just realized that I had accidentally already removed SKIP_DATEFUDGE_CHECK without pre-discussing.

Afaict the current code https://gitlab.com/ametzler/gnutls/-/blob/master/tests/scripts/common.sh#L101 does not seem to be really useful:
```sh
check_for_datefudge() {
	# On certain platforms running datefudge date fails (e.g., x86 datefudge
	# with x86-64 date app).
	if test "${SKIP_DATEFUDGE_CHECK}" = 1;then
		return
	fi

	TSTAMP=`datefudge -s "2006-09-23" "${top_builddir}/tests/datefudge-check" || true`
	if test "$TSTAMP" != "1158969600" || test "$WINDOWS" = 1; then
		return 1
	fi
}

```
It overrides checking whether datefudge works with "yes it does". I could understand the need for "do not even try to test, it is broken, just act as if it was absent", but not for "do not test whether it works but use it anyway".

Also it does not seem to be used by the current CI.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1716#note_1293909529
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20230227/13c55f57/attachment.html>